gh-124375: Avoid calling _PyMem_ProcessDelayed on other thread states#124459
Merged
colesbury merged 3 commits intopython:mainfrom Oct 15, 2024
Merged
gh-124375: Avoid calling _PyMem_ProcessDelayed on other thread states#124459colesbury merged 3 commits intopython:mainfrom
_PyMem_ProcessDelayed on other thread states#124459colesbury merged 3 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a crash when running the PyO3 test suite on the free-threaded build. The
qsbrfield is initialized after thePyThreadStateis added to the interpreter's linked list -- it might still be NULL.Instead, we "steal" the queue of to-be-freed memory blocks. This is always initialized (possibly empty) and protected by the stop the world pause.